Open
Conversation
tobias
requested changes
Apr 8, 2026
Member
tobias
left a comment
tobias
left a comment
There was a problem hiding this comment.
Thanks @frenchy64! I left a couple of suggestions, but am happy to discuss.
| #'add-hash-to-deploy-tokens-table | ||
| #'add-group-verifications-table | ||
| #'add-audit-table | ||
| #'add-token-id-to-audit-table |
Member
There was a problem hiding this comment.
Can you move this to the end of the vector? We keep the migrations in the order they were added.
| [:div.new-token | ||
| [:pre token]]))) | ||
| [:pre token]] | ||
| [:p "Token ID:"] |
Member
There was a problem hiding this comment.
I don't think we need to show the id here, since I think it would make users think they need to copy it as well. But it would be good to have a way to go from a token value to an id. Maybe instead we add another column to the token table below to show the last four digits of the token? That would require another column, as we don't store the token value, just the bcrypt and sha256 hashes of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #929
Adds token id to audit log and several other places for discoverability.
SCREENSHOT 1: Display at token creation time
SCREENSHOT 2: Add column to "Existing Deploy Tokens"
SCREENSHOT 3: Add column to "Audit log" (not tested via UI)